nion's blog - Entries from Friday, January 5. 2007

Code quality in libjabber-0.1 (centericq)

Posted by Nico Golde in random blurb
Friday, January 5. 2007

grep -n -A 10 "FIXME avoid" xmlparse.c

/* FIXME avoid integer overflow */
buffer = buffer == 0 ? malloc(len * 2) : realloc(buffer, len * 2);
if (!buffer) {
errorCode = XML_ERROR_NO_MEMORY;
eventPtr = eventEndPtr = 0;
return 0;
}
bufferLim = buffer + len * 2;
}
memcpy(buffer, end, nLeftOver);
bufferPtr = buffer;
/*** A FEW LINES LATER, SAME CODE ***/
/* FIXME avoid integer overflow */
int neededSize = len + (bufferEnd - bufferPtr);
if (neededSize <= bufferLim - buffer) {
memmove(buffer, bufferPtr, bufferEnd - bufferPtr);
bufferEnd = buffer + (bufferEnd - bufferPtr);
bufferPtr = buffer;
}
else {
char *newBuf;
int bufferSize = bufferLim - bufferPtr;
if (bufferSize == 0)

Obviously the guy who wrote this has humor.

Comments (0) - Trackbacks (0)

(Page 1 of 1, totaling 1 entries)

Calendar

Quicksearch

Support

Follow @iamnion

=>my website

Recent Entries

E-Plus GSM privacy/TMSI allocation leak: Thursday, October 11 2012
Exploiting the Ubiquisys/SFR femtocell webserver (wsal/shttpd/mongoose/yassl embedded webserver): Wednesday, August 3 2011
So what happened recently...: Wednesday, April 6 2011
: Sunday, February 6 2011
exim remote vulnerability: Thursday, December 9 2010
Will my Phone Show An Unencrypted Connection?: Wednesday, September 8 2010
smpCTF 2010 quals writeups: Sunday, August 8 2010
protocol design fail: MMS notification: Wednesday, July 28 2010
acrobat reader stealing my passwords: Tuesday, June 29 2010
UnrealIRCd backdoored: Saturday, June 12 2010

Archives

Syndicate This Blog